Restore CI for PHP 7.1+ with versioned PHPUnit configs and PHPStan cleanup#52
Merged
Restore CI for PHP 7.1+ with versioned PHPUnit configs and PHPStan cleanup#52
Conversation
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/ab96a171-0cfe-4ebc-bd6a-9b52ff092f05 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/ab96a171-0cfe-4ebc-bd6a-9b52ff092f05 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/c994b095-7d56-4d26-ab6a-452e4181411e Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/c994b095-7d56-4d26-ab6a-452e4181411e Co-authored-by: voku <264695+voku@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
voku
April 22, 2026 02:17
View session
Owner
|
@copilot will the Stringy::jsonSerialize() change trigger a deprecated notice or something like that on newer php versions? If yes, how to handle that? |
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/fb88e031-1c45-47d1-a3d4-7675a49c19b9 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/fb88e031-1c45-47d1-a3d4-7675a49c19b9 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/fb88e031-1c45-47d1-a3d4-7675a49c19b9 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Author
Yes — without extra handling PHP 8.1+ emits a deprecation for |
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/807a633f-9165-4e29-b1e9-f29041d1a64f Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/2b5f4210-b56e-44c2-bed8-9a5bb2986468 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/Stringy/sessions/fbd3e2e3-969a-4f17-9f59-a7fd64f8a534 Co-authored-by: voku <264695+voku@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is