Setup GitHub Actions CI with PHPStan, fix static analysis issues, rewrite README#26
Merged
Conversation
Agent-Logs-Url: https://github.com/voku/diridea/sessions/5ba96c27-727f-4ed7-b058-bb0ec2b97a20 Co-authored-by: voku <264695+voku@users.noreply.github.com>
- Add phpstan/phpstan to composer.json require-dev - Fix Diridea.php: add missing basePath property declaration, fix loggerVerbosity type (?int -> ?string), use default log level when verbosity is null - Fix DirValueObject.php: add declare(strict_types=1), handle null timing_value in timingValueInSeconds() - Fix all 4 process callers: handle nullable timingValueInSeconds() result - Add declare(strict_types=1) to all 16 process files missing it - Update phpunit.xml to new PHPUnit 9 schema format - Update .github/workflows/ci.yml: fix deprecated set-output, update action versions (cache@v4, upload-artifact@v4, codecov@v4, setup-php@v2), run phpstan on all PHP versions, target PHP 8.1/8.2/8.3 - Rewrite README.md with comprehensive documentation, CI badge, naming convention table, usage examples, and process type reference Agent-Logs-Url: https://github.com/voku/diridea/sessions/5ba96c27-727f-4ed7-b058-bb0ec2b97a20 Co-authored-by: voku <264695+voku@users.noreply.github.com>
…README table Agent-Logs-Url: https://github.com/voku/diridea/sessions/5ba96c27-727f-4ed7-b058-bb0ec2b97a20 Co-authored-by: voku <264695+voku@users.noreply.github.com>
- phpstan.neon: add bootstrapFiles for vendor/autoload.php so PHPStan resolves dependencies correctly when run as a phar - DirValueObject: fix @var above location() → @return; fix timingOption() comment to use proper @return tag - Diridea: fix @param $logVerbosity → $loggerVerbosity; add fully typed @param for all 7 array constructor params (null|array<int, XxxInterface>); remove redundant instanceof checks (always-true given typed annotations); remove unused DirectoryAttributes/FileAttributes imports; fix processContentHelper @param from array<int, StorageAttributes> to array<StorageAttributes>; remove stale @param from processContent - LocationDebug/LocationDefault: add @var array<string, string> on static $CACHE_DIR to fix 'Cannot access offset string on mixed' Agent-Logs-Url: https://github.com/voku/diridea/sessions/365817c7-43bf-4b54-9a0b-49a822366d7d Co-authored-by: voku <264695+voku@users.noreply.github.com>
Coverage Report for CI Build 24214396515Coverage decreased (-3.9%) to 64.865%Details
Uncovered Changes
Coverage Regressions12 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
…rents Agent-Logs-Url: https://github.com/voku/diridea/sessions/2b0d98be-5f14-424a-9a10-3f76e0a63b25 Co-authored-by: voku <264695+voku@users.noreply.github.com>
…ct constructor Agent-Logs-Url: https://github.com/voku/diridea/sessions/fbc6b744-771e-4cac-9f59-1f6866c455c9 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/diridea/sessions/45eab3fd-58c6-4d6a-85d7-ba6673f50515 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/diridea/sessions/f94a7475-6cc1-4072-8f0e-382b2b020f0c Co-authored-by: voku <264695+voku@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
level: max(≥ 8), passes with no errors — no code fixes needed.github/workflows/ci.yml.scrutinizer.yml