Allow enum $this in match without direct-object-comparison errors#60
Merged
Allow enum $this in match without direct-object-comparison errors#60
$this in match without direct-object-comparison errors#60Conversation
Coverage Report for CI Build 24965532630Coverage increased (+0.4%) to 94.935%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Coverage Report for CI Build 24964090850Coverage remained the same at 94.554%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Copilot
AI
changed the title
[WIP] Fix incorrect 'Match_: Do not compare objects directly' error for enums
Allow enum Apr 26, 2026
$this in match without direct-object-comparison errors
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/a394e53a-bb7b-405e-a31d-804fd10ee315 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/a394e53a-bb7b-405e-a31d-804fd10ee315 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/a394e53a-bb7b-405e-a31d-804fd10ee315 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/d7f26508-51c7-4907-805a-3e4fba00e5c2 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/d7f26508-51c7-4907-805a-3e4fba00e5c2 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/77b383c0-51c6-4c63-abdf-44acdb54c0a9 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/2d0c0c56-5a7b-4a73-9c06-378a977d5ad1 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/2d0c0c56-5a7b-4a73-9c06-378a977d5ad1 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/3642eed6-c15e-4ffe-b12e-e014523d4531 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/3642eed6-c15e-4ffe-b12e-e014523d4531 Co-authored-by: voku <264695+voku@users.noreply.github.com>
Agent-Logs-Url: https://github.com/voku/phpstan-rules/sessions/3642eed6-c15e-4ffe-b12e-e014523d4531 Co-authored-by: voku <264695+voku@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.