Report missed loose constant-array comparisons in IfConditionRule

[Copilot]

• Review the current loose array comparison diagnostics and affected expectations
• Reinstall dependencies and run PHPUnit/PHPStan baseline in this fresh workspace
• Replace the current array-vs-bool/null wording with guidance that explains the loose-comparison behavior is readable-but-confusing, not impossible
• Add/adjust fixture coverage for array == null / != null readability cases
• Update expected diagnostics for the refined wording
• Re-run PHPUnit, PHPStan, and final validation

[voku]

/gemini review

[coveralls]

Coverage Report for CI Build 25046427843

Coverage decreased (-0.3%) to 94.603%

Details

• Coverage decreased (-0.3%) from the base build.
• Patch coverage: 9 uncovered changes across 1 file (82 of 91 lines covered, 90.11%).
• No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
src/voku/PHPStan/Rules/IfConditionHelper.php	91	82	90.11%

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	1019
Covered Lines:	964
Line Coverage:	94.6%
Coverage Strength:	21.13 hits per line

---

💛 - Coveralls

[gemini-code-assist]

Code Review

This pull request introduces a new helper method extractSingleConstantArrayType to IfConditionHelper and integrates it into processEqualRules and processNotEqualRules to detect type mismatches involving constant arrays. It also adds several test cases and fixtures to verify these new rules and prevent regressions. The review feedback highlights significant issues with the error messages: the grammar is incorrect, and more importantly, the logic for 'Not Equal' comparisons is inverted, as disjoint types result in a condition that is always true rather than falsy. Additionally, there is an opportunity to refactor the duplicated logic for constant scalars and arrays into a shared method.

[gemini-code-assist]

The logic for checking constant arrays is identical to the logic for constant scalars (lines 255-269). Consider refactoring this into a shared private method to improve maintainability and avoid duplication.

Additionally, the error message has a grammatical issue: "Condition ... are falsy" should be "Condition ... is falsy".

Finally, note that using accepts(..., true)->no() for loose equality (==) can be misleading. For example, [] == null and [] == false are true in PHP, but this rule will report them as "falsy" because null and false do not strictly accept an array. While this might be intended to enforce strictness, the wording "are falsy" is technically incorrect in those cases.

        $type_1ConstantArray = self::extractSingleConstantArrayType($type_1);
        if (
            $type_1ConstantArray !== null
            &&
            $type_2
            &&
            $type_2->accepts($type_1ConstantArray, true)->no()
        ) {
            $errors[] = self::buildErrorMessage(
                $origNode,
                sprintf('Condition between %s and %s is always false, please do not mix types.', $type_1ConstantArray->describe(VerbosityLevel::value()), $type_2->describe(VerbosityLevel::value())),
                $cond->getAttribute('startLine')
            );
        }

[gemini-code-assist]

In addition to the duplication and grammar issues mentioned in processEqualRules, the error message here is logically incorrect for a "Not Equal" (!=) comparison. If the types are disjoint (accepts()->no()), the condition is actually always true, not "falsy". Reporting it as "falsy" will be confusing to users.

        $type_1ConstantArray = self::extractSingleConstantArrayType($type_1);
        if (
            $type_1ConstantArray !== null
            &&
            $type_2
            &&
            $type_2->accepts($type_1ConstantArray, true)->no()
        ) {
            $errors[] = self::buildErrorMessage(
                $origNode,
                sprintf('Condition between %s and %s is always true, please do not mix types.', $type_1ConstantArray->describe(VerbosityLevel::value()), $type_2->describe(VerbosityLevel::value())),
                $cond->getAttribute('startLine')
            );
        }