Updated @volar/source-map/README based on PR(#207)#247
Closed
alamhubb wants to merge 2 commits into
Closed
Conversation
Member
|
@alamhubb Sorry for the delay,
The mapping between virtual code and source code may be discrete or continuous. Some functions should only be mapped in a continuous range (such as formatting). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm trying to develop a custom syntax lsp plugin based on ts recently, using volar.js, which is really great, saving me a lot of work and letting me learn a lot.
I'm learning about the functions of the code mapping related parts, and I found that the document description in
https://github.com/volarjs/volar.js/blob/master/packages/source-map/README.md
and the code implementation in
https://github.com/volarjs/volar.js/blob/master/packages/source-map/lib/sourceMap.ts are inconsistent, so I tried to synchronize this document
There is also a about
volar.js/packages/source-map/lib/sourceMap.ts
Line 71 in 03d1e8b
* findMatchingStartEndI am a little confused about this method. I see that in this method, whenfallbackToAnyMatch = trueis judged, it will break if it matches one, but the non-fallbackToAnyMatchcode block above does not break. What is the reason?I am also curious about the situation where there will be a start and end position of the source code, corresponding to the start and end positions of multiple generated codes.