feat: Full web support#47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR decouples synchronous file reading logic. Now the file system of the language server can be synchronous or asynchronous, and the synchronous/asynchronous differentiated behavior is determined by the downstream services.
Specifically, volar-service-typescript will first return that the file does not exist when reading a file asynchronously, and re-execute the TS API after getting the asynchronous result.
We are also abstracting the logic of automatically obtaining dts from CDN in the web environment to volar-service-typescript, instead of implementing them from lsp server and monaco respectively.
Todos:
Respect tsdk path forgetDefaultLibFileNamerequest-lightmaxFileSizesupport