Skip to content

Tweak configuration.py#1466

Merged
ikelos merged 1 commit intovolatilityfoundation:developfrom
j-t-1:configuration
Dec 25, 2024
Merged

Tweak configuration.py#1466
ikelos merged 1 commit intovolatilityfoundation:developfrom
j-t-1:configuration

Conversation

@j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Dec 24, 2024

Create a tuple directly and replace random.choice by random.choices.

@j-t-1
Tweak configuration.py
79fe1c5 
Create a tuple directly and replace random.choice by random.choices.
ikelos
ikelos approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ikelos ikelos merged commit 93b09fd into volatilityfoundation:develop Dec 25, 2024
@j-t-1
Copy link
Contributor Author

j-t-1 commented Dec 25, 2024

Should line 784 include a float as a simple type? Differs from line 49.

@j-t-1 j-t-1 deleted the configuration branch December 25, 2024 20:09
@ikelos
Copy link
Member

ikelos commented Dec 25, 2024

floats weren't supposed to be part of the BasicTypes and I don't think they're used anywhere? That should probably use the variable though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikelos ikelos ikelos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-t-1 @ikelos