Skip to content

ci: publish images to GitHub Container Registry too #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volcano-sh-bot merged 1 commit into from
Dec 22, 2025
Merged

ci: publish images to GitHub Container Registry too #4846

volcano-sh-bot merged 1 commit into from
Dec 22, 2025

Conversation

@medyagh
Copy link
Contributor

@medyagh medyagh commented Dec 21, 2025 •
edited
Loading

What type of PR is this?

publishes docker images into github ctonainer registry in addition to docker.io

GitHub Container Registry (ghcr.io):

ghcr.io/volcano-sh/vc-scheduler:latest (or version tag)
ghcr.io/volcano-sh/vc-controller-manager:latest
ghcr.io/volcano-sh/vc-webhook-manager:latest
ghcr.io/volcano-sh/vc-agent:latest

What this PR does / why we need it:

in order to comply with minikube integration test requirements and not be rate limited by docker.io

Which issue(s) this PR fixes:

closes #4845

Fixes #

Special notes for your reviewer:

To keep volcano integration tests with minikube it is required to be publishing images somwhere with no rate limit

Does this PR introduce a user-facing change?

related kubernetes/minikube#22076

Copilot AI review requested due to automatic review settings December 21, 2025 23:06
@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 21, 2025

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Dec 21, 2025

Welcome @medyagh! It looks like this is your first PR to volcano-sh/volcano 🎉

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 21, 2025
Copilot AI reviewed Dec 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the CI/CD pipeline to publish Docker images to GitHub Container Registry (ghcr.io) in addition to Docker Hub, addressing rate limiting concerns for minikube integration tests.

  • Adds authentication step for GitHub Container Registry using built-in GITHUB_TOKEN
  • Introduces a parallel release workflow that pushes images to both Docker Hub and ghcr.io
  • Updates logout procedure to cleanly disconnect from both registries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2025
hzxuzhonghu
hzxuzhonghu reviewed Dec 22, 2025
View reviewed changes
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Dec 22, 2025

@medyagh Please make the DCO check happy

@medyagh medyagh force-pushed the add_ghcr branch 2 times, most recently from 7720db8 to 8f1d352 Compare December 22, 2025 06:36
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Dec 22, 2025

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 22, 2025
hzxuzhonghu
hzxuzhonghu reviewed Dec 22, 2025
View reviewed changes
@medyagh
Copy link
Contributor Author

medyagh commented Dec 22, 2025

@medyagh Please make the DCO check happy

done :)

medyagh
medyagh commented Dec 22, 2025
View reviewed changes
@medyagh
Copy link
Contributor Author

medyagh commented Dec 22, 2025

@hzxuzhonghu I think the project admins would need to enable the "github packages" in the repo to make it work

hzxuzhonghu
hzxuzhonghu approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Dec 22, 2025

github packages has been enabled and used by another sub project

hajnalmt
hajnalmt suggested changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@hajnalmt hajnalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I encountered rate limiting issues with Docker hub too.
I had some minor comments, please address them plus squash your commits too!

@JesseStutler
Copy link
Member

JesseStutler commented Dec 22, 2025

Hi, thanks for your contribution, could you squash your commits? This will help us organize the release notes and allow others easier to track your modifications

@medyagh
feat: Add GitHub Container Registry support
3cda63c 
Signed-off-by: Medya Ghazizadeh <medya@google.com>
@medyagh
Copy link
Contributor Author

medyagh commented Dec 22, 2025

Hi, thanks for your contribution, could you squash your commits? This will help us organize the release notes and allow others easier to track your modifications

done

hajnalmt
hajnalmt approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@hajnalmt hajnalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for the change!

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hajnalmt, hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 1fab5f7 into volcano-sh:master Dec 22, 2025
20 of 21 checks passed
This was referenced Dec 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@lowang-bh lowang-bh Awaiting requested review from lowang-bh

@merryzhou merryzhou Awaiting requested review from merryzhou

+1 more reviewer

@hajnalmt hajnalmt hajnalmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hajnalmt hajnalmt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish images other than docker.io for rate limitted

5 participants

@medyagh @volcano-sh-bot @hzxuzhonghu @JesseStutler @hajnalmt