feat(vikingbot): self-evolving agent memory with experience injection

[yangxinxin-7]

Summary

• Fix agent memory URI: use openviking_config.agent_id instead of workspace_id, preventing namespace mismatch when agent_id is unconfigured in ov.conf
• Disable agent memory in auto recall: experience memories are not searched during auto recall — only user memory is; experience injection is now done proactively at the right call sites
• Inject experience memory on skill load: via PostCallHook on read_file, experience context is prepended when a skill file is loaded
• Inject experience memory on subagent spawn: relevant experiences are injected into subagent task prompts before dispatch
• Inject experience memory before write-related tool calls: before write_file / edit_file, the LLM response is rolled back and re-called with experience context; guarded by a write_exp_injected flag so it only fires once per message
• Gate all injection features via config: agent_memory_enabled and exp_write_tools fields added to OpenVikingConfig

Implementation discussed with @huangruiteng.

🤖 Generated with Claude Code

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🏅 Score: 80

🧪 No relevant tests

🔒 No security concerns identified

✅ No TODO sections

🔀 Multiple PR themes Sub-PR theme: Fix agent memory URI and disable auto recall Relevant files: bot/vikingbot/config/schema.py bot/vikingbot/openviking_mount/ov_server.py Sub-PR theme: Add experience memory injection for skills and subagents Relevant files: bot/vikingbot/agent/memory.py bot/vikingbot/agent/subagent.py bot/vikingbot/hooks/builtins/openviking_hooks.py Sub-PR theme: Add experience memory injection before write tools Relevant files: bot/vikingbot/agent/loop.py

⚡ Recommended focus areas for review Possible AttributeError _search_skill_experiences assumes exp is a dict and calls exp.get(), but doesn't handle the case where exp is an object. This would raise an AttributeError if search_experiences returns objects instead of dicts. uri = exp.get("uri", "") score = exp.get("score", 0) if score < 0.3: continue

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Support both dict and object experience items Handle both dict and object types for exp (same as in memory.py). This prevents AttributeError if exp is an object instead of a dict, which matches the pattern used elsewhere in the codebase. bot/vikingbot/hooks/builtins/openviking_hooks.py [110-115] for exp in experiences: - uri = exp.get("uri", "") - score = exp.get("score", 0) + uri = exp.get("uri", "") if isinstance(exp, dict) else getattr(exp, "uri", "") + score = exp.get("score", 0) if isinstance(exp, dict) else getattr(exp, "score", 0) if score < 0.3: continue content = await ov_client.read_content(uri, level="read") Suggestion importance[1-10]: 5 __ Why: This improves robustness by handling both dict and object types for exp items, consistent with the pattern used in memory.py, preventing potential AttributeErrors.	Low

[yeshion23333]

I found two blocking issues and a few follow-up suggestions. The main concerns are workspace-scoped OpenViking routing regressing to a global singleton in hooks, and skill memory retrieval being replaced by experience search instead of being augmented.