docs(bot): document ov_server.api_key_type and exp_write_tools (#1994 + #2007)#2014
Merged
MaojiaSheng merged 4 commits intoMay 19, 2026
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
MaojiaSheng
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document two
bot.ov_serverconfig fields added by recent feat PRs:api_key_type(added by feat(bot):Support user-key OpenViking mode and align memory namespaces #1994, merged 2026-05-13):root(default) keeps the original root-key fanout behavior;userswitches the bot to the user-key flow for OpenViking client calls.exp_write_tools(added by feat(vikingbot): self-evolving agent memory with experience injection #2007, merged 2026-05-13): list of tool names that trigger experience-memory injection before invocation (self-evolving agent memory loop). Defaults to["write_file", "edit_file"].Both fields exist in
OpenVikingConfig(bot/vikingbot/config/schema.py) but were not documented inbot/README.mdorbot/README_CN.md. This patch adds 2 bullets per file (4 lines total, additive only) to the existingov_serversub-list — same byte-mirror style as the surroundingroot_api_key/account_identries.Why call out the
agent_memory_enabledgate onexp_write_toolsexp_write_toolsonly takes effect when the OpenViking server hasmemory.agent_memory_enabled = true(defined inopenviking_cli/utils/config/memory_config.pyasMemoryConfig.agent_memory_enabled: bool = False, checked byopenviking/session/compressor_v2.py). That gate lives in a different config namespace (server-sidememory.*, not bot-sidebot.ov_server.*), so the bullet states it explicitly to avoid the surprise of "I set exp_write_tools but nothing happens."Verification
api_key_type: schema lineapi_key_type: Literal["root", "user"] = "root"(bot/vikingbot/config/schema.py:513), validator strips/lowercases input. Doc keeps to the verified contract from feat(bot):Support user-key OpenViking mode and align memory namespaces #1994 body wording; full client flow deferred to the source PR.exp_write_tools: schema lineexp_write_tools: list[str] = Field(default_factory=lambda: ["write_file", "edit_file"])(bot/vikingbot/config/schema.py:519). Gate verified atcompressor_v2.py:46(if not getattr(config.memory, "agent_memory_enabled", False): return []).bot/README*.mdfor these fields (sibling-PR check clean).Diff scope
Codex adversarial review
gpt-5.5 xhigh):VERDICT: needs-attention— flagged missingagent_memory_enabledgate onexp_write_tools(0.85) and overclaimedapi_key_typelifecycle (0.55).gpt-5.5 xhigh) on this V2:VERDICT: approve— both findings resolved by tightening wording and adding the gate disclosure.🤖 Generated with Claude Code