Skip to content

fix(claude-code-memory-plugin): improve Windows compatibility#1249

Merged
Mijamind719 merged 2 commits intovolcengine:mainfrom
Castor6:fix/claude-code-memory-plugin-windows
Apr 14, 2026
Merged

fix(claude-code-memory-plugin): improve Windows compatibility#1249
Mijamind719 merged 2 commits intovolcengine:mainfrom
Castor6:fix/claude-code-memory-plugin-windows

Conversation

@Castor6
Copy link
Copy Markdown
Contributor

@Castor6 Castor6 commented Apr 6, 2026

Summary

  • enable shell mode for runtime bootstrap commands on Windows so npm ci runs correctly during plugin setup
  • replace ${OPENVIKING_CONFIG_FILE:-} with ${OPENVIKING_CONFIG_FILE} in .mcp.json because the default-value syntax is not portable to the Windows environment expansion used by Claude Code
  • document the config override and Windows path separator expectations in both English and Chinese READMEs
  • bump the Claude plugin manifest version to 0.1.2

Validation

  • Static check: node --check examples/claude-code-memory-plugin/scripts/runtime-common.mjs
  • Static check: node -e "JSON.parse(require('fs').readFileSync('examples/claude-code-memory-plugin/.claude-plugin/plugin.json','utf8')); JSON.parse(require('fs').readFileSync('examples/claude-code-memory-plugin/.mcp.json','utf8')); console.log('json ok')"
  • Manual verification: validated successfully in a real Windows environment after applying this change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@Castor6
Copy link
Copy Markdown
Contributor Author

Castor6 commented Apr 13, 2026

@Mijamind719 大佬帮忙 check 一下这个 pr ,已经一周了谢谢啦

@Mijamind719 Mijamind719 self-assigned this Apr 13, 2026
@Mijamind719
Copy link
Copy Markdown
Collaborator

@Mijamind719 大佬帮忙 check 一下这个 pr ,已经一周了谢谢啦

建议顺手把 package.json 和 MCP server 内的版本号也同步到 0.1.2,避免后续日志和排障时出现版本混淆。

@Castor6
Copy link
Copy Markdown
Contributor Author

Castor6 commented Apr 13, 2026

@Mijamind719 好的,其实我已经在我插件仓库更新到新版0.1.4了,下个pr会对这些文件做版本号的谢谢

@Mijamind719 Mijamind719 merged commit e9915ec into volcengine:main Apr 14, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants