fix CI: correct patch targets in test_quick_start_lite.py#140
Merged
MaojiaSheng merged 3 commits intovolcengine:mainfrom Feb 12, 2026
Merged
fix CI: correct patch targets in test_quick_start_lite.py#140MaojiaSheng merged 3 commits intovolcengine:mainfrom
MaojiaSheng merged 3 commits intovolcengine:mainfrom
Conversation
The test was patching 'openviking.utils.config.embedding_config.EmbeddingConfig' and 'openviking.utils.config.vlm_config.VLMConfig' but these modules are now exported directly from 'openviking.utils.config'. Changed patch targets to: - openviking.utils.config.EmbeddingConfig.get_embedder - openviking.utils.config.VLMConfig.get_vlm_instance
ZaynJarvis
changed the title
The test modifies sys.path before importing from openviking, which is intentional for test isolation. Added noqa comment to suppress the linter warning.
ZaynJarvis
changed the title
ZaynJarvis
changed the title
kkkwjx07
approved these changes
Feb 12, 2026
MaojiaSheng
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test-lite workflow was failing with:
Root Cause
The test was patching:
openviking.utils.config.embedding_config.EmbeddingConfig.get_embedderopenviking.utils.config.vlm_config.VLMConfig.get_vlm_instanceBut these classes are now exported directly from
openviking.utils.config(via__init__.py), not as submodules.Fix
Changed patch targets to:
openviking.utils.config.EmbeddingConfig.get_embedderopenviking.utils.config.VLMConfig.get_vlm_instanceTesting