Skip to content

fix(volcengine): update default doubao embedding model#1438

Merged
qin-ctx merged 1 commit intomainfrom
fix/update-doubao-embedding-model
Apr 14, 2026
Merged

fix(volcengine): update default doubao embedding model#1438
qin-ctx merged 1 commit intomainfrom
fix/update-doubao-embedding-model

Conversation

@qin-ctx
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx commented Apr 14, 2026

Description

Update default Doubao embedding model references to doubao-embedding-vision-251215 across user-facing configuration examples and cloud setup defaults.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Refresh README, contributing guides, FAQ/getting-started/configuration docs, and example configs to use doubao-embedding-vision-251215
  • Update Helm/example values and local evaluation dataset snippets so generated sample configs stay consistent with the supported Volcengine embedding model
  • Change the cloud setup wizard default embedding model and align telemetry usage tests; pre-commit also reformats openviking_cli/setup_wizard.py

Testing

  • Ran python -m pytest --override-ini addopts='' tests/models/test_embedding_telemetry_usage.py
  • Reviewed the staged diff to confirm the updated model ID is consistent across docs, examples, and defaults
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

  • ruff format reformatted openviking_cli/setup_wizard.py during the commit hook.

Align docs, examples, the setup wizard, and telemetry tests with the
current Doubao multimodal embedding model so generated configs keep
referencing the supported default consistently.
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Documentation Inconsistency

Release date for doubao-embedding-vision-251215 is listed as 2025-06-15, which mismatches the model's date suffix (251215 = 2025-12-15).

| Doubao-Embedding-Vision | `doubao-embedding-vision-251215` | 2025-06-15 |
Documentation Inconsistency

Release date for doubao-embedding-vision-251215 is listed as 2025-06-15, which mismatches the model's date suffix (251215 = 2025-12-15).

| Doubao-Embedding-Vision | `doubao-embedding-vision-251215` | 2025-06-15 |

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@ZaynJarvis
Copy link
Copy Markdown
Collaborator

lgtm

@qin-ctx qin-ctx merged commit 3c2f095 into main Apr 14, 2026
5 of 6 checks passed
@qin-ctx qin-ctx deleted the fix/update-doubao-embedding-model branch April 14, 2026 07:51
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants