Skip to content

Add doctor Ollama coverage#1499

Merged
ZaynJarvis merged 1 commit intovolcengine:mainfrom
duyua9:add-doctor-ollama-tests
Apr 17, 2026
Merged

Add doctor Ollama coverage#1499
ZaynJarvis merged 1 commit intovolcengine:mainfrom
duyua9:add-doctor-ollama-tests

Conversation

@duyua9
Copy link
Copy Markdown
Contributor

@duyua9 duyua9 commented Apr 16, 2026

Summary\n- add focused check_ollama unit coverage for missing/non-Ollama configs\n- verify embedding and VLM Ollama api_base values are passed to the health check\n- cover the unreachable Ollama diagnostic path without requiring a real Ollama process\n\n## Validation\n- python3 -m py_compile tests/cli/test_doctor.py\n- PYTHONPATH=. uv run --no-project --with ruff python -m ruff check tests/cli/test_doctor.py\n- PYTHONPATH=. uv run --no-project --with pytest --with pytest-cov --with httpx --with pydantic --with pyyaml --with loguru --with rich --with json-repair python -m pytest --confcutdir=tests/cli tests/cli/test_doctor.py -k ollama

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 16, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@ZaynJarvis ZaynJarvis merged commit af9780c into volcengine:main Apr 17, 2026
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants