fix(cli): ov chat auth from config with required headers#1575
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Apr 20, 2026
Merged
fix(cli): ov chat auth from config with required headers#1575qin-ctx merged 1 commit intovolcengine:mainfrom
qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
- chat.rs: Load api_key/account/user from Config when not provided via CLI - chat.rs: Add X-OpenViking-Account and X-OpenViking-User headers - config.rs: Add serde aliases for account_id/user_id field names - main.rs: Pass account/user from config to ChatCommand Fixes volcengine#1574
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Collaborator
|
Thanks for your contribution. May I ask whether the conversation works properly after the fix? Could you also share a screenshot showing a normal response? |
qin-ctx
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1574
This PR fixes
ov chatcommand failing with 401 Unauthorized even when valid credentials are configured inovcli.conf.Problem
ov chatwas not readingapi_key,account, anduserfrom the configuration file, and was not sending the requiredX-OpenViking-AccountandX-OpenViking-Userheaders for API_KEY auth mode.Changes
1.
crates/ov_cli/src/commands/chat.rsaccountanduserCLI arguments toChatCommandChatAuthstruct to hold resolved authentication inforesolve_auth()method to load auth from Config when not provided via CLIapply_auth_headers()helper to send all required headerssend_message*methods to use the new auth flow2.
crates/ov_cli/src/config.rs#[serde(alias = "account_id")]onaccountfield#[serde(alias = "user_id")]onuserfieldaccount_id/user_idaliases3.
crates/ov_cli/src/main.rsaccountanduserfromctx.configtoChatCommandconstructionTesting
Before:
$ ov chat -m "hello" Error: API error: Request failed (401 Unauthorized): Missing API Key...After:
Checklist
cargo build --release -p ov_cli)ov chatcommandaccount/userandaccount_id/user_idfield namesAI Assistant Note: This fix was identified through code analysis by Hermes Agent with Codex tooling. See #1574 for full investigation details.