Skip to content

docs(en): list dashscope in embedding provider table (#1535)#1584

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
r266-tech:docs/en-embedding-provider-dashscope-1535
Apr 20, 2026
Merged

docs(en): list dashscope in embedding provider table (#1535)#1584
qin-ctx merged 1 commit intovolcengine:mainfrom
r266-tech:docs/en-embedding-provider-dashscope-1535

Conversation

@r266-tech
Copy link
Copy Markdown
Contributor

#1535 added DashScope (Alibaba Tongyi) as a first-class embedding provider (openviking/models/embedder/dashscope_embedders.py, factory registration in openviking_cli/utils/config/embedding_config.py, validator accepting provider="dashscope" at line 209). The PR also added a full DashScope example section further down in docs/en/guides/01-configuration.md (lines 303–347).

The Dense Embedding parameters quick-reference table at line 122 still enumerates only the six legacy providers and does not mention dashscope, so a reader scanning the parameter table has no hint that DashScope is a valid provider value until they scroll another ~180 lines down.

docs/zh/guides/01-configuration.md (line 124) already lists dashscope in the equivalent zh table, so this is a pure EN/ZH parity + config-source-of-truth fix (embedding_config.py:40 lists dashscope among the 12 valid providers).

Change

docs/en/guides/01-configuration.md line 122: +1 token ("dashscope") inserted into the provider enum, ordering mirrors zh.

Docs-only, no code logic change.

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1535 - Fully compliant

Compliant requirements:

  • Update English documentation to list DashScope in the embedding provider table
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 100
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit 67464fa into volcengine:main Apr 20, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants