docs(en): list dashscope in embedding provider table (#1535)#1584
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Apr 20, 2026
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
qin-ctx
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1535 added DashScope (Alibaba Tongyi) as a first-class embedding provider (
openviking/models/embedder/dashscope_embedders.py, factory registration inopenviking_cli/utils/config/embedding_config.py, validator acceptingprovider="dashscope"at line 209). The PR also added a full DashScope example section further down indocs/en/guides/01-configuration.md(lines 303–347).The Dense Embedding parameters quick-reference table at line 122 still enumerates only the six legacy providers and does not mention
dashscope, so a reader scanning the parameter table has no hint that DashScope is a validprovidervalue until they scroll another ~180 lines down.docs/zh/guides/01-configuration.md(line 124) already listsdashscopein the equivalent zh table, so this is a pure EN/ZH parity + config-source-of-truth fix (embedding_config.py:40listsdashscopeamong the 12 valid providers).Change
docs/en/guides/01-configuration.mdline 122: +1 token ("dashscope") inserted into the provider enum, ordering mirrors zh.Docs-only, no code logic change.