feat: add ClawHub publishing#1587
Conversation
…pport Made-with: Cursor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
qin-ctx
left a comment
There was a problem hiding this comment.
Blocking issues found in the ClawHub setup flow and Windows runtime persistence.
| function writeOpenvikingEnv(pythonPath: string): void { | ||
| if (!fs.existsSync(OPENCLAW_DIR)) fs.mkdirSync(OPENCLAW_DIR, { recursive: true }); | ||
| if (IS_WIN) { | ||
| fs.writeFileSync(path.join(OPENCLAW_DIR, "openviking.env.bat"), `@echo off\r\nset "OPENVIKING_PYTHON=${pythonPath}"\r\n`, "utf-8"); |
There was a problem hiding this comment.
[Bug] (blocking) On Windows, the wizard writes openviking.env.bat as set "OPENVIKING_PYTHON=...", but both readers only match set OPENVIKING_PYTHON=... without the surrounding quotes. That means the path you persist here cannot be recovered later by either the setup wizard or normal gateway startup, so OPENVIKING_PYTHON silently stops being reusable after the first run. Please make the writer and both readers accept the same syntax, and add a Windows round-trip test for the .bat format.
| const defaultConfigPath = existing?.configPath ? String(existing.configPath) : DEFAULT_CONFIG_PATH; | ||
| const defaultPort = existing?.port ? String(existing.port) : String(DEFAULT_PORT); | ||
|
|
||
| const cfgPath = await q(tr(zh, "Config path", "配置文件路径"), defaultConfigPath); |
There was a problem hiding this comment.
[Bug] (blocking) This local-mode setup flow saves configPath and tells the user to run openclaw gateway --force, but it never verifies that ov.conf exists or is valid, and it never generates one. With the docs now recommending openclaw plugins install clawhub:@openclaw/openviking + openclaw openviking setup as the primary install path, a first-time user can complete the wizard successfully and still hit an immediate startup failure on the next gateway launch because openviking.server.config.load_server_config() requires a real ov.conf. Please either validate-and-block here, generate a minimal config, or explicitly route first-time local installs through the existing ov-install flow.
Description
Add openclaw openviking setup interactive wizard — detects Python, verifies OpenViking package, writes config
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes