docs(skill): sync ov add-memory output example after #1613#1627
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Apr 22, 2026
Merged
Conversation
PR volcengine#1613 changed 'ov add-memory' to print 'OK' instead of memories_extracted count because commit runs async. The SKILL.md example still showed the old count output.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
qin-ctx
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ov add-memoryCLI output documented inexamples/skills/ov-add-data/SKILL.mdno longer matches actual behavior after #1613 (merged 2026-04-21 by @qin-ctx).crates/ov_cli/src/commands/session.rswas changed to emit a simple"OK"because the commit endpoint runs asynchronously andmemories_extractedisn't meaningful at response time:But
SKILL.mdstill shows the old expected output:An agent reading this skill to decide whether
add-memorysucceeded will be confused when the CLI just printsOK.Fix
Update the "Output" section in
examples/skills/ov-add-data/SKILL.mdto reflect the newOKoutput and note that extraction runs async after commit is queued.Type of Change
Test plan
#1613'ssession.rschange (output_success(&json!("OK"), ...))add-memoryoutput example in the repo needs updating (memories_extractedstill appears indocs/{en,zh}/api/05-sessions.mdanddocs/{en,zh}/concepts/08-session.mdbut those document the/commitHTTP API response body, which still carriesmemories_extracted— not the CLI)Checklist