fix(session): allow explicit role_id passthrough#1643
Merged
Conversation
Allow add-message callers to persist explicit role_id values without USER gating or server-side format normalization.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
chenjw
approved these changes
Apr 22, 2026
19 tasks
r266-tech
added a commit
to r266-tech/OpenViking
that referenced
this pull request
Apr 23, 2026
…gh + no server-side format check)
qin-ctx
pushed a commit
that referenced
this pull request
Apr 23, 2026
…rver-side format check) (#1657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow session add-message requests to persist explicit
role_idvalues without server-side caller-role or format enforcement.Related Issue
Type of Change
Changes Made
USER-specific rejection path for explicit session messagerole_idvalues.role_idformat on the sessions add-message route and only auto-fill when the field is missing or empty.role_idpassthrough forUSERrequests, including raw sender-style identifiers.Testing
Local verification:
python -m pytest -o addopts='' tests/server/test_api_sessions.pypython -m compileall openviking/server/routers/sessions.py tests/server/test_api_sessions.pyChecklist
Screenshots (if applicable)
Additional Notes
Existing test output includes pre-existing Pydantic deprecation warnings unrelated to this change.