[fix] Fix/oc2ov test stability

[kaisongli]

Description

Related Issue

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Test update

Changes Made

Testing

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have tested this on the following platforms:
  • Linux
  • macOS
  • Windows

Checklist

• My code follows the project's coding style
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 85

🧪 No relevant tests

🔒 No security concerns identified

✅ No TODO sections

🔀 Multiple PR themes Sub-PR theme: Improve test stability with retries and unstable response handling Relevant files: tests/oc2ov_test/tests/base_cli_test.py tests/oc2ov_test/tests/p0/test_context_engine.py tests/oc2ov_test/tests/p0/test_memory_crud.py Sub-PR theme: Adjust CI workflow triggers and timeouts Relevant files: .github/workflows/api_test.yml .github/workflows/api_test_effect.yml .github/workflows/oc2ov_test.yml

⚡ Recommended focus areas for review Workflow Condition Change The updated 'if' condition may skip push events to main in forked repositories, which was previously allowed. This could reduce test coverage for fork contributors. if: github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request' || github.repository == 'volcengine/OpenViking' Workflow Condition Change The updated 'if' condition may skip push events in forked repositories, which was previously allowed. This could reduce test coverage for fork contributors. if: github.event_name == 'workflow_dispatch' || github.repository == 'volcengine/OpenViking' Assertion Skipping Assertion methods now skip checks when LLM responses are unstable, which improves stability but could mask real test failures. Consider adding a strict mode or logging the skipped assertions more prominently. if self._is_llm_unstable_response(response): self.logger.warning(f"LLM 不稳定，跳过关键词断言: {keywords}") return Duplicate Unstable Check Logic Unstable response detection logic is duplicated between smart_wait_for_sync and _is_llm_unstable_response. Consolidating this would reduce maintenance overhead and ensure consistency. unstable = ( not text or any( ind in text.lower() for ind in [ "idle timeout", "couldn't generate", "please try again", "no_reply", ] ) or (text.startswith('[{"name"') and len(text) < 300) or text == "}]" )

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Use shared unstable check method Remove the duplicated unstable response check in check_response() and use the newly added _is_llm_unstable_response() method instead. This ensures consistent unstable response detection across the codebase and reduces maintenance overhead. tests/oc2ov_test/tests/base_cli_test.py [155-173] response = self.client.send_message(check_message, session_id=target_session_id) -text = self.assertion.extract_response_text(response).strip() -unstable = ( - not text - or any( - ind in text.lower() - for ind in [ - "idle timeout", - "couldn't generate", - "please try again", - "no_reply", - ] - ) - or (text.startswith('[{"name"') and len(text) < 300) - or text == "}]" -) -if unstable: +if self._is_llm_unstable_response(response): self.logger.warning("LLM 不稳定，跳过 smart_wait 关键词检查") return True Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies duplicated unstable response detection logic in check_response() and proposes using the new shared _is_llm_unstable_response() method instead, which improves consistency and maintainability.	Low