Skip to content

feat(parse): support larkoffice.com Feishu document URLs#1684

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
efishliu:feature/support-larkoffice
Apr 24, 2026
Merged

feat(parse): support larkoffice.com Feishu document URLs#1684
qin-ctx merged 1 commit intovolcengine:mainfrom
efishliu:feature/support-larkoffice

Conversation

@efishliu
Copy link
Copy Markdown
Contributor

Summary

Support *.larkoffice.com Feishu document URLs (docx/wiki/sheets/base), allowing bytedance.larkoffice.com/wiki/... to be routed through the FeishuParser instead of generic HTML fetch.

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Documentation (docs)
  • Refactoring (refactor)
  • Other

Changes Made

  • Problem: *.larkoffice.com/wiki/... was currently treated as generic HTML fetch, resulting in a login page or 404 content instead of correct Feishu document parsing.
  • Fix: Extended Feishu URL detection (_is_feishu_url and _ALLOWED_FEISHU_HOSTS) to include *.larkoffice.com and correctly route FeishuParser.parse_content() for such URLs.
  • Tests: Added regression tests for URL detection and parse_content routing.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • Code follows project style guidelines
  • Tests added for new functionality

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


liugang.9766 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 98
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit 3069b4b into volcengine:main Apr 24, 2026
1 of 2 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants