You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The normalize_encoding default value is inconsistent with the test expectation and Rust plugin defaults. Change the default to False to align with the test test_agfs_s3_normalize_encoding_defaults_to_false and the Rust codebase.
normalize_encoding: bool = Field(
- default=True,+ default=False,
description="Normalize URL-unsafe path segments before writing S3 object keys. "
"When enabled, reserved or unsafe URL bytes such as ?, &, #, spaces, %, @, or + are "
"escaped in place as !HH hexadecimal bytes, while / ! - _ . * ' ( ) remain unescaped.",
)
Suggestion importance[1-10]: 8
__
Why: The default value for normalize_encoding in S3Config is inconsistent with the test expectation (test_agfs_s3_normalize_encoding_defaults_to_false) and Rust plugin defaults (both use False). Fixing this avoids test failures and ensures cross-codebase consistency.
Medium
General
Update normalize_encoding doc default
Align the documented default value for normalize_encoding with the actual code defaults (False). This ensures consistency between documentation and implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes