Skip to content

Fix/oc2ov v2 session 404#1824

Merged
qin-ctx merged 2 commits intovolcengine:mainfrom
kaisongli:fix/oc2ov-v2-session-404
May 6, 2026
Merged

Fix/oc2ov v2 session 404#1824
qin-ctx merged 2 commits intovolcengine:mainfrom
kaisongli:fix/oc2ov-v2-session-404

Conversation

@kaisongli
Copy link
Copy Markdown
Collaborator

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

When OV reuses existing sessions instead of creating new ones,
find_new_session_id returns None. Now tries commit on all existing
sessions to find one with pending messages. Also handles 404 and
task_id=None gracefully, falling back to checking memory files
directly.
OV auto-capture may take a few seconds to create a new session after
OpenClaw sends a message. Increased initial wait from 5s to 8s, and
added up to 3 retries with 5s intervals when session not found.
Falls back to committing all existing sessions if still not found.
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 85
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Broad Exception Handling

The code uses except Exception: without logging on lines 644 and 702, which can hide real errors and make debugging harder.

except Exception:
    continue
Broad Exception Handling

The code uses except Exception: without logging on line 702, which can hide real errors and make debugging harder.

except Exception:
    pass

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit b66d51c into volcengine:main May 6, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants