Skip to content

docs(openclaw-plugin): drop agent_end from README hook list per #1866#1871

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
r266-tech:docs-openclaw-plugin-drop-agent-end-1866
May 7, 2026
Merged

docs(openclaw-plugin): drop agent_end from README hook list per #1866#1871
qin-ctx merged 1 commit intovolcengine:mainfrom
r266-tech:docs-openclaw-plugin-drop-agent-end-1866

Conversation

@r266-tech
Copy link
Copy Markdown
Contributor

Summary

#1866 (Mijamind719→ qin-ctx, merged 2026-05-06T08:50Z) explicitly removed the agent_end hook from examples/openclaw-plugin/index.ts because OpenClaw 5.2 blocks that typed hook for non-bundled plugins without conversation access (per the PR description: "the agent_end hook is removed because 5.2 blocks that typed hook for non-bundled plugins without conversation access; session routing is already recorded through session_start/session_end.").

After the merge, examples/openclaw-plugin/index.ts only registers session_start, session_end, and before_reset (verified with grep -n "api.on(" examples/openclaw-plugin/index.ts):

api.on("session_start", async (_event, ctx) => { ... });
api.on("session_end",   async (_event, ctx) => { ... });
api.on("before_reset",  async (_event, ctx) => { ... });

But the hook-layer bullet in README.md (line 22) and README_CN.md (line 22) still list agent_end. Drop it so the README matches the runtime registration.

Scope

  • examples/openclaw-plugin/README.md — removed , + `agent_end` from the hook-layer bullet
  • examples/openclaw-plugin/README_CN.md — removed `agent_end`、 from the same bullet (Chinese)

Pure docs, no code or behavior change. Refs #1866.

…ngine#1866

volcengine#1866 explicitly removed the agent_end hook from index.ts because OpenClaw 5.2 blocks that typed hook for non-bundled plugins without conversation access; session routing is now recorded through session_start/session_end. README.md and README_CN.md still listed agent_end in the hook-layer summary.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1866 - Fully compliant

Compliant requirements:

  • Update documentation to remove agent_end hook from README lists
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 100
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit f10e900 into volcengine:main May 7, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants