chore(format): align python and c++ file formatting#2001
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
1. bump urllib3 dependency from 2.6.3 to 2.7.0 2. remove unused pytest import and RoleScope import from test file
Adjust the line breaks in the list comprehension in the VikingSearchTool class to follow standard Python formatting conventions, and rewrap the lambda assignment in the test case to improve code readability without changing functionality.
- remove stray blank line in ov_server.py - wrap long logger.info line in memory.py for better readability
This commit removes unused imports, reorders import statements for better consistency, and simplifies some test file imports. Changes include: - Remove redundant blank lines and unused imports across multiple test files and core modules - Reorder imports in openviking hooks module to follow standard layout - Fix import ordering in memory isolation handler - Simplify php parser type imports - Move volcengine mock import to correct position in test file
clean up redundant whitespace to improve code readability
qin-ctx
approved these changes
May 13, 2026
zhoujh01
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns Python and C++ source files with the repository's current formatting standards.
It applies repository-standard formatting across tracked Python and C++ files to reduce style drift, keep diffs consistent, and make future PR checks easier to pass.
Related Issue
Type of Change
Changes Made
.clang-formatconfiguration.Testing
Additional verification performed:
ruff format --check bot build_support openviking testspassed after formatting.ruff check bot build_support openviking testsstill reports pre-existing lint issues outside the scope of this formatting-only PR.Checklist
Screenshots (if applicable)
N/A
Additional Notes
This PR is intended to be formatting-only.
Scope notes:
pyproject.tomlRuff settings..clang-format.third_party/content was not reformatted.ruff checklint findings remain and are not addressed in this PR.