Feat/memory link#2010
Merged
Merged
Conversation
Keep dry-run patch validation from emitting a misleading patch_handler warning, and record skipped field updates from MemoryUpdater where the failure is handled. 🤖 Generated with [Aiden x Claude Code] Co-Authored-By: Aiden
qin-ctx
requested changes
May 20, 2026
Collaborator
qin-ctx
left a comment
There was a problem hiding this comment.
这次 review 结论是 REQUEST_CHANGES。核心问题集中在 page_id/link 生命周期没有闭环,并且当前 CI 的 lint job 失败。
Blocking:
- PageIdMap 的实现和新增测试/设计不一致,PR head 上单跑 tests/unit/session/memory/test_page_id_map.py 会出现 16 个 AttributeError。
- 多 URI / 多用户场景下同一个 page_id 会被后续 URI 覆盖,link resolution 会指向错误文件。
- page_id map 没有挂到 ExtractContext,supplement_operation_uris() 读取不到它,page_id 锚定编辑不会生效。
- CI lint 失败:ruff format --check 报 24 个文件需要 reformat。
Non-blocking:PR 目前有 76 个文件和 96 个 commits,且包含 memory link、VLM thinking、patch、profile 模板、path lock 等多条独立行为线;建议拆分或 squash。PR body 也还保留模板占位,未关联 issue、未勾选类型/测试项,需要补齐。
Expand _resolve_links so shared page ids resolve across every operation URI instead of collapsing to a single path. Align the page-id and extract-loop tests with the current API contract and the multi-URI link behavior. 🤖 Generated with [Aiden x Claude Code] Co-Authored-By: Aiden
qin-ctx
requested changes
May 20, 2026
Collaborator
qin-ctx
left a comment
There was a problem hiding this comment.
本次复查仍发现一个 blocking 问题:new page_id 的多 URI 写入会在 apply 阶段被压成单 URI,需要修复后再合并。
qin-ctx
approved these changes
May 21, 2026
Expand the TAU-2 benchmark harness for trajectory-memory retrieval, corpus reuse, and fixed-first-user evidence runs so prompt and eval changes can be exercised together. Align trajectory extraction with reusable operation contracts and update usage-audit docs/runtime to match the new workflow. 🤖 Generated with [Aiden x Claude Code] Co-Authored-By: Aiden
Apply the remaining formatter-driven cleanup in the memory modules so the working tree stays clean before the next behavior changes. This keeps helper signatures and string literals aligned with current lint output. 🤖 Generated with [Aiden x Claude Code] Co-Authored-By: Aiden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"memory" : {
"link_enabled": true
},
curl -X POST "http://127.0.0.1:1933/api/v1/relations/build_graph"
-H "Content-Type: application/json"
-H "X-API-Key: default"
-H "X-OpenViking-Account: default"
-H "X-OpenViking-User: agent_sample_5"
-d '{
"space_uris": [
"viking://user",
"viking://agent"
],
"output_uri":
"viking://.combined.graph.html"
}'
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes