Skip to content

Feat/memory link#2010

Merged
chenjw merged 105 commits into
mainfrom
feat/memory_link
May 21, 2026
Merged

Feat/memory link#2010
chenjw merged 105 commits into
mainfrom
feat/memory_link

Conversation

@chenjw
Copy link
Copy Markdown
Collaborator

@chenjw chenjw commented May 13, 2026

Description

  1. 修复vlm配置中的thinking参数无效的问题。
  2. 加强字段级别的language指定。
  3. 支持字段级别的searchable属性,控制是否进embedding
  4. 支持记忆文件间的链接提取,默认关闭,通过ov.conf配置打开
    "memory" : {
    "link_enabled": true
    },
  5. 在relations下支持build_graph命令,为子目录生成graph可视化文件。
    curl -X POST "http://127.0.0.1:1933/api/v1/relations/build_graph"
    -H "Content-Type: application/json"
    -H "X-API-Key: default"
    -H "X-OpenViking-Account: default"
    -H "X-OpenViking-User: agent_sample_5"
    -d '{
    "space_uris": [
    "viking://user",
    "viking://agent"
    ],
    "output_uri":
    "viking://.combined.graph.html"
    }'
  6. 优化了patch机制:(1)原始内容带行号;(2)patch失败增加了一次llm重试。
  7. profile.yaml进行了简化,偏好相关信息强制挪到prefrences.yaml
  8. locomo 81%指标正常。

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@chenjw chenjw changed the title [WIP] Feat/memory link 先别通过 Feat/memory link May 20, 2026
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这次 review 结论是 REQUEST_CHANGES。核心问题集中在 page_id/link 生命周期没有闭环,并且当前 CI 的 lint job 失败。

Blocking:

  1. PageIdMap 的实现和新增测试/设计不一致,PR head 上单跑 tests/unit/session/memory/test_page_id_map.py 会出现 16 个 AttributeError。
  2. 多 URI / 多用户场景下同一个 page_id 会被后续 URI 覆盖,link resolution 会指向错误文件。
  3. page_id map 没有挂到 ExtractContext,supplement_operation_uris() 读取不到它,page_id 锚定编辑不会生效。
  4. CI lint 失败:ruff format --check 报 24 个文件需要 reformat。

Non-blocking:PR 目前有 76 个文件和 96 个 commits,且包含 memory link、VLM thinking、patch、profile 模板、path lock 等多条独立行为线;建议拆分或 squash。PR body 也还保留模板占位,未关联 issue、未勾选类型/测试项,需要补齐。

Comment thread openviking/session/memory/page_id_map.py
Comment thread openviking/session/memory/page_id_map.py
Comment thread openviking/session/memory/session_extract_context_provider.py Outdated
chenjw added 3 commits May 20, 2026 18:26
Expand _resolve_links so shared page ids resolve across every operation URI instead of collapsing to a single path. Align the page-id and extract-loop tests with the current API contract and the multi-URI link behavior.

🤖 Generated with [Aiden x Claude Code]

Co-Authored-By: Aiden
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次复查仍发现一个 blocking 问题:new page_id 的多 URI 写入会在 apply 阶段被压成单 URI,需要修复后再合并。

Comment thread openviking/session/memory/utils/uri.py Outdated
chenjw added 4 commits May 21, 2026 11:51
Expand the TAU-2 benchmark harness for trajectory-memory retrieval, corpus reuse, and fixed-first-user evidence runs so prompt and eval changes can be exercised together. Align trajectory extraction with reusable operation contracts and update usage-audit docs/runtime to match the new workflow.

🤖 Generated with [Aiden x Claude Code]

Co-Authored-By: Aiden
Apply the remaining formatter-driven cleanup in the memory modules so the working tree stays clean before the next behavior changes. This keeps helper signatures and string literals aligned with current lint output.

🤖 Generated with [Aiden x Claude Code]

Co-Authored-By: Aiden
@chenjw chenjw merged commit 85908e2 into main May 21, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 21, 2026
@chenjw chenjw deleted the feat/memory_link branch May 21, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants