Skip to content

fix: add input validation to search_by_id method#209

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
aeromomo:fix/search-robustness
Feb 19, 2026
Merged

fix: add input validation to search_by_id method#209
qin-ctx merged 1 commit intovolcengine:mainfrom
aeromomo:fix/search-robustness

Conversation

@aeromomo
Copy link
Contributor

  • Add null/empty ID validation to prevent crashes
  • Handle invalid ID conversion gracefully (ValueError, OverflowError)
  • Return empty SearchResult for invalid inputs instead of raising exceptions
  • Improve robustness for edge cases like None, empty strings, invalid formats

This prevents potential crashes when search_by_id is called with malformed or invalid ID values, making the search API more robust.

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

- Add null/empty ID validation to prevent crashes
- Handle invalid ID conversion gracefully (ValueError, OverflowError)
- Return empty SearchResult for invalid inputs instead of raising exceptions
- Improve robustness for edge cases like None, empty strings, invalid formats

This prevents potential crashes when search_by_id is called with
malformed or invalid ID values, making the search API more robust.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


OpenClaw Integration seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qin-ctx qin-ctx merged commit 3be6d0a into volcengine:main Feb 19, 2026
1 check was pending
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants