Skip to content

Support Vaka memory templates via a switch#2130

Merged
chenjw merged 2 commits into
volcengine:mainfrom
fujiajie666:vaka_prompt_template
May 19, 2026
Merged

Support Vaka memory templates via a switch#2130
chenjw merged 2 commits into
volcengine:mainfrom
fujiajie666:vaka_prompt_template

Conversation

@fujiajie666
Copy link
Copy Markdown
Collaborator

Description

Using enable_vaka_template field as a switch to enable custom memory templates for Vaka.

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 92
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Dead Code

The else block on lines 489-490 sets memory_templates_dir but does not use it, resulting in dead code. This likely stems from a logic change where the bundled templates directory is now always used as the first entry in self._schema_directories.

else:
    memory_templates_dir = str(resolve_memory_templates_dir())

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@chenjw chenjw merged commit fc5ed54 into volcengine:main May 19, 2026
4 of 5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 19, 2026
config = get_openviking_config()
custom_dir = config.memory.custom_templates_dir
self._schema_directories = [memory_templates_dir]
if config.memory.enable_vaka_template:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里做成 config.memory.template_type == 'vaka' 的拓展性更好?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants