bench(tau2): add generic scope fairness check#2172
Merged
yangxinxin-7 merged 3 commits intoMay 21, 2026
Conversation
PR Reviewer Guide 🔍(Review updated until commit af1d2f0)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit af1d2f0 |
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a narrow follow-up to #2017. PR-B showed that TAU-2 trajectory memory can beat the no-memory baseline, but the headline read compared a no-scope no-memory baseline against a trajectory-memory treatment that used a domain-specific scope prompt. This PR removes the domain-specific scope prompts, routes TAU-2 scope treatments through a benchmark-neutral generic prompt, and adds the missing no-memory scope plumbing so the fair attribution read can use the same generic scope on both sides.
Changes:
scope_prompt_filethrough the no-memory TAU-2 eval path, so no-memory can be measured under the same scope prompt as memory treatmentsWhy
The original domain scope prompt is useful, but it can also help no-memory runs and is harder to defend as a benchmark-neutral memory protocol. Without a same-scope baseline, the headline PR-B delta can over-attribute some scope-prompt benefit to memory. The new generic-scope config makes the fair read explicit and reproducible without embedding retail/airline-specific business hints.
The important read is the attribution boundary:
So the headline result remains positive, but the benchmark-neutral fair read is the generic-scope delta (
+0.04375). The same-domain-scope row is retained only as an attribution diagnostic explaining why the original mixed-scope read was too generous.Validation
Local checks:
python3 -m py_compile benchmark/tau2/scripts/run_eval.pypython3 benchmark/tau2/scripts/run_eval.py --config benchmark/tau2/config/prb_scope_fairness.yaml --run-id pr_scope_fairness_generic_only_preflight2 --domain retail --repeat-count 1 --num-tasks 1 --strategy-id no_memory_generic_scope --strict-preflight --plan-onlypython3 benchmark/tau2/scripts/run_eval.py --config benchmark/tau2/config/trajectory.yaml --run-id pr_trajectory_generic_scope_plancheck --domain retail --repeat-count 1 --num-tasks 1 --strategy-id memory_v2_trajectory_prewrite_scope --strict-preflight --plan-onlybenchmark/tau2/config/scope_prompts/generic_memory_scope.mdFull 8-trial diagnostic runs above come from the PR-B follow-up workspace. The original PR-B headline row is included to show the mixed-scope attribution issue; the generic-scope row is the fair read enabled by this PR.
Boundary
This PR does not add category rerank, selector/controller logic, failure-memory handling, or outcome-aware experience aggregation. Those remain separate experimental lines.