Skip to content

fix(helm): refresh OpenViking chart defaults#2189

Merged
t0saki merged 1 commit into
mainfrom
zeus/helm-chart-refresh
May 22, 2026
Merged

fix(helm): refresh OpenViking chart defaults#2189
t0saki merged 1 commit into
mainfrom
zeus/helm-chart-refresh

Conversation

@ZaynJarvis
Copy link
Copy Markdown
Collaborator

@ZaynJarvis ZaynJarvis commented May 22, 2026

Summary

  • default the Helm chart to ghcr.io/volcengine/openviking:latest and decouple image selection from Chart.appVersion
  • document latest / main / pinned tags such as v0.3.17; an empty image.tag also falls back to latest
  • align Kubernetes deployment with the current Docker image layout by using /app/.openviking/ov.conf, the image entrypoint, and OPENVIKING_WITH_BOT=0 by default
  • update persistence defaults/docs and secret-based API key examples so the Service still exposes only port 1933

Validation

  • helm lint deploy/helm/openviking
  • helm template openviking deploy/helm/openviking --namespace default
  • helm template openviking deploy/helm/openviking --namespace default --set image.tag= renders ghcr.io/volcengine/openviking:latest
  • git diff --check
  • deployed with helm upgrade --install openviking ./deploy/helm/openviking --namespace default --set image.tag=main ... --wait --timeout 10m
  • verified kubectl get svc shows ClusterIP with only 1933/TCP
  • verified local port-forward 127.0.0.1:1933 -> svc/openviking:1933, /health, /ready, and authenticated /api/v1/system/status
  • verified installed ov CLI can connect via a temporary ovcli.conf, read/write viking://resources/helm-smoke/cli-20260522T071348Z.md, and retrieve it with ov find
  • verified workspace persistence by restarting deployment/openviking, then reading and finding the same smoke-test resource after the new pod became Ready

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 90
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@ZaynJarvis ZaynJarvis force-pushed the zeus/helm-chart-refresh branch from 23399d4 to 5002a33 Compare May 22, 2026 07:31
Copy link
Copy Markdown
Collaborator

@t0saki t0saki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0saki t0saki merged commit 6042a8f into main May 22, 2026
5 checks passed
@t0saki t0saki deleted the zeus/helm-chart-refresh branch May 22, 2026 07:37
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants