fix(helm): refresh OpenViking chart defaults#2189
Merged
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
23399d4 to
5002a33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghcr.io/volcengine/openviking:latestand decouple image selection fromChart.appVersionlatest/main/ pinned tags such asv0.3.17; an emptyimage.tagalso falls back tolatest/app/.openviking/ov.conf, the image entrypoint, andOPENVIKING_WITH_BOT=0by defaultValidation
helm lint deploy/helm/openvikinghelm template openviking deploy/helm/openviking --namespace defaulthelm template openviking deploy/helm/openviking --namespace default --set image.tag=rendersghcr.io/volcengine/openviking:latestgit diff --checkhelm upgrade --install openviking ./deploy/helm/openviking --namespace default --set image.tag=main ... --wait --timeout 10mkubectl get svcshowsClusterIPwith only1933/TCP127.0.0.1:1933 -> svc/openviking:1933,/health,/ready, and authenticated/api/v1/system/statusovCLI can connect via a temporaryovcli.conf, read/writeviking://resources/helm-smoke/cli-20260522T071348Z.md, and retrieve it withov finddeployment/openviking, then reading and finding the same smoke-test resource after the new pod became Ready