refactor(langchain): clarify session commit policy helper#2283
Merged
ZaynJarvis merged 1 commit intoMay 28, 2026
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
ZaynJarvis
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maybe_commit_sessiontoapply_commit_policy.OpenVikingChatMessageHistoryandOpenVikingContextMiddlewareto call the renamed helper after message capture.Rationale
The helper does more than opportunistically commit a session: it applies the configured
OpenVikingCommitPolicyacrossnever,always, andpending_tokensmodes. The new name better matches the behavior used by both the chat history adapter and LangGraph middleware, and keeps the lifecycle API easier to reason about before adding more integration surfaces.Validation
uv run --extra dev ruff format openviking/integrations/langchain/client.py openviking/integrations/langchain/history.py openviking/integrations/langchain/middleware.py tests/unit/test_langchain_integration.pyuv run --extra dev ruff check openviking/integrations/langchain/client.py openviking/integrations/langchain/history.py openviking/integrations/langchain/middleware.py tests/unit/test_langchain_integration.pyuv run --extra test pytest tests/unit/test_langchain_integration.py --no-cov -q