Skip to content

docs: fix broken crates/ov_cli/LICENSE link in README/README_CN/README_JA (404 since #1221 crates reorg)#2289

Merged
qin-ctx merged 3 commits into
volcengine:mainfrom
r266-tech:oss-fix-license-link-1221
May 29, 2026
Merged

docs: fix broken crates/ov_cli/LICENSE link in README/README_CN/README_JA (404 since #1221 crates reorg)#2289
qin-ctx merged 3 commits into
volcengine:mainfrom
r266-tech:oss-fix-license-link-1221

Conversation

@r266-tech
Copy link
Copy Markdown
Contributor

All 3 top-level READMEs link the crates/ov_cli Apache 2.0 license to ./crates/ov_cli/LICENSE, which 404s since #1221 (2026-04-05, MaojiaSheng) consolidated the per-crate Apache LICENSEs up one level to ./crates/LICENSE (one Apache 2.0 file now covers ov_cli + ragfs + ragfs-python).

Trilingual one-line path fix — each README changes [LICENSE](./crates/ov_cli/LICENSE)[LICENSE](./crates/LICENSE). The **crates/ov_cli**: Apache 2.0 label wording is left untouched (minimal byte-grounded mirror of where the file actually lives — broaden the label scope in a follow-up if you prefer).

Verified live targets via gh api repos/.../contents/:

  • crates/LICENSE → exists (Apache 2.0)
  • crates/ov_cli/LICENSE → 404
  • examples/LICENSE → exists (untouched in this PR)

@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1221 - Partially compliant

Compliant requirements:

  • N/A (this PR fixes a documentation issue caused by the ticket's changes)

Non-compliant requirements:

  • N/A

Requires further human verification:

  • N/A
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 100
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit 007831d into volcengine:main May 29, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants