Skip to content

fix(vectordb): add ap-southeast-1 region host mappings for VikingDB#2297

Merged
qin-ctx merged 1 commit into
volcengine:mainfrom
abinch:fix/volcengine-ap-southeast-1
May 29, 2026
Merged

fix(vectordb): add ap-southeast-1 region host mappings for VikingDB#2297
qin-ctx merged 1 commit into
volcengine:mainfrom
abinch:fix/volcengine-ap-southeast-1

Conversation

@abinch
Copy link
Copy Markdown
Contributor

@abinch abinch commented May 29, 2026

Description

When deploying OpenViking with volcengine vectordb backend and region: "ap-southeast-1", a KeyError is raised because the _global_host dictionaries in both ClientForConsoleApi and ClientForDataApi only contain Chinese mainland regions.

This PR adds the missing host entries for the ap-southeast-1 (Johor) region.

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Added "ap-southeast-1": "vikingdb.ap-southeast-1.volcengineapi.com" to ClientForConsoleApi._global_host
  • Added "ap-southeast-1": "api-vikingdb.vikingdb.ap-southeast-1.volces.com" to ClientForDataApi._global_host

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx
Copy link
Copy Markdown
Collaborator

qin-ctx commented May 29, 2026

thanks!

@qin-ctx qin-ctx merged commit 934c8fc into volcengine:main May 29, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants