fix(fs): ls --simple skips abstract fetching and returns only URIs#236
Merged
MaojiaSheng merged 1 commit intovolcengine:mainfrom Feb 22, 2026
Merged
Conversation
When simple=True, short-circuit early using output='original' to avoid expensive abstract fetching (_batch_fetch_abstracts), then extract only the uri field. This fixes volcengine#218 where --simple with output=agent returned empty strings because agent format omits name/rel_path fields. Follows author guidance to save tokens by keeping only the uri column. Fixes volcengine#218
MaojiaSheng
approved these changes
Feb 22, 2026
This was referenced Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ls --simplereturning empty output whenoutput=agent(the default). The agent format omitsname/rel_pathfields, causing the old fallback chain to fail silently.Now
simple=Trueshort-circuits early: usesoutput="original"to skip expensive abstract fetching (_batch_fetch_abstracts), then extracts only theurifield. This follows the author's guidance ("只保留 uri 列") to save tokens.Type of Change
Testing
tests/client/test_filesystem.py::TestLs::test_ls_simple_mode)viking://URIstest_ls_simple_agent_outputfor the specificoutput=agent+simple=TruescenarioRelated Issues