refactor(storage): deprecated and remove agfs http mode client#2425
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
qin-ctx
requested changes
Jun 4, 2026
Collaborator
qin-ctx
left a comment
There was a problem hiding this comment.
Review summary: requesting changes for one runtime regression in the binding-only AGFS helpers. The overall direction of removing the legacy AGFS HTTP path looks sound.
Non-blocking suggestion: CONTRIBUTING.md still says OpenViking defaults to binding-client mode for AGFS and references AGFS (Go). Since this PR standardizes on RAGFS Rust binding-only access, please update that contributor guidance as well; it cannot be posted as an inline comment because CONTRIBUTING.md is not part of this PR diff.
qin-ctx
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the legacy AGFS HTTP client path and standardize OpenViking on binding-only RAGFS access. This change also updates typing, tests, and docs so the repository consistently reflects the binding-only AGFS architecture while preserving backward compatibility for deprecated
storage.agfs.*config fields such asmode.Related Issue
Type of Change
Changes Made
AGFSClientHTTP implementation and the Rustragfs-serverHTTP entrypoints and dependencies.AGFSSyncClientProtocoland updateasync_client,helpers, QueueFS, and transaction code to depend on a sync AGFS protocol instead of the deleted concrete HTTP client type.Testing
Validation performed locally:
cargo build -p ragfsovCLI smoke tests formkdir,write,read,stat,mv,get, andrmChecklist
Screenshots (if applicable)
N/A
Additional Notes
storage.agfs.mode,url,impl,port,use_ssl, and related legacy fields remain accepted byAGFSConfigand are only warned as deprecated/ignored, so old configs do not fail to parse during startup.ovCLI, orAsyncHTTPClient/SyncHTTPClientwhen they talk to an OpenViking server.