Skip to content

Comments

fix Invalid isoformat string on Windows due to high-precision timestamps#252

Merged
MaojiaSheng merged 1 commit intovolcengine:mainfrom
kscale:main
Feb 22, 2026
Merged

fix Invalid isoformat string on Windows due to high-precision timestamps#252
MaojiaSheng merged 1 commit intovolcengine:mainfrom
kscale:main

Conversation

@kscale
Copy link
Contributor

@kscale kscale commented Feb 22, 2026

fix bug ValueError: Invalid isoformat string on Windows due to high-precision timestamps #242

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

fix bug ValueError: Invalid isoformat string on Windows due to high-precision timestamps volcengine#242
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

@kscale kscale changed the title Update viking_fs.py fix Invalid isoformat string on Windows due to high-precision timestamps Feb 22, 2026
@MaojiaSheng MaojiaSheng merged commit ca41da3 into volcengine:main Feb 22, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants