fix: use reason as instruction fallback in resource processing#258
Merged
MaojiaSheng merged 2 commits intovolcengine:mainfrom Feb 23, 2026
Merged
Conversation
Windows may produce ISO 8601 timestamps with 7-digit fractional seconds (e.g. .1470042), which Python's datetime.fromisoformat() rejects with ValueError. Add a parse_iso_datetime() helper that truncates excess digits before parsing. Fixes volcengine#242 Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
The reason parameter in process_resource() was accepted but never used, despite being documented as improving search relevance. Use reason as fallback for instruction when instruction is empty, so it influences L0/L1 generation via the media processor. Fixes volcengine#243 Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
|
|
MaojiaSheng
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
reasonparameter inprocess_resource()is documented as improving search relevance, but it is never actually used — the variable is accepted and silently discarded.Fix
Use
reasonas a fallback forinstructionwheninstructionis empty. This way,reasoninfluences L0/L1 generation via the media processor, fulfilling its documented purpose.When both are provided,
instructiontakes precedence (more specific). When onlyreasonis provided, it serves as the processing context.Fixes #243