fix(memory): remove duplicate name field in identity template#2943
Merged
qin-ctx merged 1 commit intoJul 2, 2026
Merged
Conversation
The identity.yaml memory template defined the `name` field twice in the fields list — once without `init_value` (line 24-27) and again with `init_value: ""` (line 35-39). The first definition was redundant and likely a copy-paste leftover. Remove the duplicate so the field list has a single canonical `name` definition (the one with `init_value: ""`, matching the pattern used by other fields like `creature`). No runtime impact — Pydantic model generation silently kept the last definition — but the duplicate could confuse template readers and future edits.
qin-ctx
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate
namefield definition inidentity.yamlmemory templateRelated Issue
Type of Change
Testing
Checklist
Screenshots (if applicable)
Additional Notes