fix(plugin): memcommit session resolution and legacy commit compatibility#697
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 17, 2026
Merged
Conversation
|
|
qin-ctx
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
memcommitfor the OpenCode memory plugin example.It resolves two related issues:
Changes
context.sessionIDinstead ofcontext.session?.idwhen resolving the current OpenCode sessionmemcommitandmemsearchPOST /api/v1/sessions/{id}/commitwhen the server does not provide/api/v1/tasksWhy
The OpenCode plugin
ToolContextexposessessionID, notsession.id.Also, the plugin example currently needs to work against both:
Without this compatibility handling,
memcommitcan fail even when the session mapping itself is valid.Notes
This change does not yet alter the user-facing
memcommitwaiting behavior. It focuses on correctness and compatibility first.