feat: add memory extract telemetry breakdown#735
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
qin-ptr
left a comment
There was a problem hiding this comment.
Review Summary
This PR adds detailed telemetry breakdown for memory extract operations, including candidates statistics (total/standard/tool_skill), action results (created/merged/deleted/skipped), and 12 stage-wise timing breakdowns. The implementation uses measure() context manager for automatic timing and accumulation, with comprehensive documentation improvements.
Blocking Issues
-
[Bug] PR Description - The PR description is empty (only template placeholders remain). Must add description explaining what was changed (adding memory extract telemetry breakdown) and why (for performance analysis and problem diagnosis).
-
[Design] Telemetry initialization strategy inconsistent with documentation - see inline comment on compressor.py:239
-
[Bug] Potential undefined property in JavaScript output - see inline comment on app.js:1740
Non-blocking Suggestions
- Add test coverage for VLM unavailable scenario
- Fix documentation format inconsistency ("范围" vs "备注")
Please address the blocking issues before merging. See inline comments for detailed explanations and suggested fixes.
098b8b9 to
4b33da4
Compare
4b33da4 to
de4e8d5
Compare
feat: add resource telemetry breakdown telemetry: omit zero-valued summary fields feat(resources): add temp upload telemetry support docs: move telemetry guide out of design docs: sync contributor build requirements
de4e8d5 to
7190994
Compare
- Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs volcengine#505, volcengine#728, volcengine#749, volcengine#740/volcengine#745, volcengine#754, volcengine#735, volcengine#767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
…#780) - Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs #505, #728, #749, #740/#745, #754, #735, #767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
Description
Related Issue
Type of Change
Changes Made
核心变更分 4 块:
app.js
openviking/utils/resource_processor.py 的 telemetry 采集
Testing
Checklist
Screenshots (if applicable)
Additional Notes