fix: use _max_concurrent_semantic for Semantic queue worker instead of hardcoded 1#877
Closed
r266-tech wants to merge 1 commit intovolcengine:mainfrom
Closed
fix: use _max_concurrent_semantic for Semantic queue worker instead of hardcoded 1#877r266-tech wants to merge 1 commit intovolcengine:mainfrom
r266-tech wants to merge 1 commit intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
The _max_concurrent_semantic variable was stored in QueueManager.__init__ but never used in _start_queue_worker. The Semantic queue worker always had max_concurrent=1, ignoring the configured vlm.max_concurrent value. Fixes volcengine#873
r266-tech
force-pushed
the
fix/semantic-queue-concurrency
branch
from
b155230 to
2c3c22d
Compare
|
|
zeattacker
pushed a commit
to zeattacker/OpenViking
that referenced
this pull request
Mar 24, 2026
Per-message: skip expensive LLM overview generation when ≤5 files changed and cached overview exists. Rebuild overview from summaries without LLM call (0 LLM calls vs 3 batches × 10+ min each). Daily at 04:00 WIB (21:00 UTC): full LLM regen for directories with file count delta ≥ 5 since last run, keeping overviews coherent. Also applies PR volcengine#877 fix: use _max_concurrent_semantic for queue worker concurrency instead of hardcoded 1. Default set to 2 to match llama.cpp parallel slots. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you for your code. I just merged in the same fix（https://github.com/volcengine/OpenViking/pull/905）, so I'm closing this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #873
The variable was stored in
QueueManager.__init__but never used in_start_queue_worker. The Semantic queue worker always ran withmax_concurrent=1, ignoring the configuredvlm.max_concurrentvalue for queue-level task concurrency.Change
Before:
After:
Impact
max_concurrent_semanticparameter (default: 100)ov.confviavlm.max_concurrent