Refactor(CLI): Centralize ov.conf JSON loading in ov doctor#913
Merged
MaojiaSheng merged 1 commit intovolcengine:mainfrom Mar 24, 2026
Merged
Conversation
|
Failed to generate code suggestions for PR |
MaojiaSheng
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves ov doctor by loading ov.conf through a small shared helper that only catches OSError and json.JSONDecodeError, instead of a broad Exception. Aligns Ruff’s target-version with the package’s requires-python (3.10+). Adds unit tests for invalid JSON on embedding and VLM checks.
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
N/A — CLI / tooling only.
Additional Notes
check_config still uses explicit JSON error messaging for the primary config validation path; only the secondary reads were deduplicated.