fix(embed): give warning when embeder and vectoerdb are not the same.#930
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 24, 2026
Merged
Conversation
|
Failed to generate code suggestions for PR |
4eb77d7 to
394d6be
Compare
394d6be to
7a977d9
Compare
|
xiaogang.zhou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
qin-ctx
approved these changes
Mar 24, 2026
|
xiaogang.zhou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
zeattacker
pushed a commit
to zeattacker/OpenViking
that referenced
this pull request
Mar 25, 2026
…ngine#930) Cherry-pick from upstream d95ee7d. Warns when vectordb and embedding dimensions don't match to prevent silent search failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a configuration validation step to check the consistency of vector dimensions. It compares the
dimensionspecified forstorage.vectordbwith thedimensionconfigured forembedding. If both values are greater than 0 but do not match, the system will log a warning to help users catch potential vector search errors early.Related Issue
N/A
Type of Change
Changes Made
OpenVikingConfig.from_dict(openviking_cli/utils/config/open_viking_config.py).logging.warningoutput to notify users of dimension mismatches.ruffformatting to the modified code blocks to ensure styling compliance.Testing
Checklist
Screenshots (if applicable)
N/A
Additional Notes
The warning uses the standard
loggingmodule directly to avoid infinite recursion that could occur ifget_loggertriggers config initialization before the config object is fully loaded.