Fix Windows engine wheel runtime packaging#993
Merged
Conversation
fix(windows): link abi3 engine against python3 runtime chore(windows): drop unused mingw engine dll bundling
|
Failed to generate code suggestions for PR |
MaojiaSheng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
这次提交 828db85 主要修复了 Windows 下 openviking.storage.vectordb.engine 的 wheel 运行时加载问
题,并顺手清理了已确认无用的 MinGW DLL 打包逻辑。
之前 engine 的 .pyd 在 Windows 上会绑定到类似 python310.dll 的版本化运行时,导致在 Python 3.12
上安装新包后仍然导入失败。现在构建阶段会显式传递 stable ABI 所需的 Python runtime 路径,并在
CMake 中统一使用 stable ABI 链接方式,避免再依赖 Python3::Python。
在 engine loader 中继续注册 engine/、openviking/lib/、openviking/bin/ 这些目录,确保 wheel 安装
后的 Windows 运行时能正确找到包内依赖 DLL。
已确认当前 engine .pyd 不再依赖 libstdc++-6.dll、libgcc_s_、libwinpthread-1.dll 等 MinGW
runtime DLL,因此移除了构建时复制这些 DLL 到 engine/ 目录的逻辑,也移除了 engine/.dll 的打包配
置,减少 wheel 冗余内容。
新增测试覆盖:
在 GitHub Actions 的 Windows wheel 构建流程中增加导入 smoke test,确保构建产物至少能完成 import
openviking.storage.vectordb.engine。
Files Changed
Test Plan
test_vectordb_engine_loader.py tests/cli/test_doctor.py -q