remove arrow from Canonical::empty #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
requested changes
Jan 28, 2025
| dtype.is_nullable(), | ||
| ) | ||
| .into_canonical() | ||
| builder_with_capacity(dtype, 0).finish()?.into_canonical() |
Contributor
There was a problem hiding this comment.
Can we make sure that infer_data_type matches this builder. I think that should also be fixed in this PR
Contributor
There was a problem hiding this comment.
Why do we care about arrow data types?
joseph-isaacs
approved these changes
Jan 28, 2025
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
I guess infer data type is an unrelated problem
Contributor
|
ah, I just found this in fuzzer, thanks for fixing it @onursatici |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow Lists are nullable but elements of those lists are not. In
Identity::return_dtype, previous behaviour returnedlist(i64?)?when givenlist(i64)?