IntoArrow compute function #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
approved these changes
Jan 29, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I left a comment because the todo is not actually something you want to do...
| ) -> VortexResult<Option<ArrayRef>> { | ||
| let array_ref = match data_type { | ||
| DataType::BinaryView | DataType::FixedSizeBinary(_) | DataType::Utf8View => { | ||
| // TODO(ngates): we should support converting VarBin into these Arrow arrays. |
Contributor
There was a problem hiding this comment.
This is actually handled, because BinaryView and Utf8View are canonical so the fallback will canonicalize.
Note: We don't want this to be implemented here since converting our varbin to arrow varbin might copy offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a ToArrow compute function that takes a target Arrow DType.
This allows us in the future to support e.g.
DictArray::to_arrow(DataType::Dictionary(...))which currently isn't possible with the into_canonical hack we use for VarBin.