Segment prefetcher #2613
Merged
Segment prefetcher #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
Benchmarks: TPC-H on S3Table of Results
|
onursatici
force-pushed
the
os/scan
branch
2 times, most recently
from
a30f27c to
6bf0490
Compare
gatesn
reviewed
Mar 12, 2025
robert3005
reviewed
Mar 12, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
Did a first pass, I think I need to spend more time looking at ordering and cancellations
Co-authored-by: Robert Kruszewski <github@robertk.io>
Co-authored-by: Robert Kruszewski <github@robertk.io>
Co-authored-by: Robert Kruszewski <github@robertk.io>
gatesn
approved these changes
Mar 13, 2025
| } | ||
|
|
||
| impl SegmentCollector { | ||
| pub fn with_priority_hint(&self, kind: RequiredSegmentKind) -> Self { |
Contributor
There was a problem hiding this comment.
This is a bit weird, that e.g. LayoutReaders are exposed to this API and have the possibility of calling it at all
| &self, | ||
| layout: &Layout, | ||
| row_offset: u64, | ||
| filter_field_mask: &[FieldMask], |
Contributor
There was a problem hiding this comment.
I think you should just take a single field mask and call this function twice?
| /// Compute masks of field paths referenced by the projection and filter in the scan. | ||
| /// | ||
| /// Projection and filter must be pre-simplified. | ||
| fn filter_and_projection_masks( |
Contributor
There was a problem hiding this comment.
This function kind of does two things interleaved? Can you just have a single function that returns a FieldMask from an ExprRef + DType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.