feat: integrate cargo into cmake build #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+32
to
+33
| target_link_libraries(${EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-static) | ||
| target_link_libraries(${LOADABLE_EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-shared) |
Contributor
There was a problem hiding this comment.
I think we can kill these now
Contributor
Author
There was a problem hiding this comment.
This is where we link the vortex_duckdb rust lib against the extension.
E.g. build_static_extension defines a library target ${NAME}_extension.
function(build_static_extension NAME PARAMETERS)
# all parameters after name
set(FILES "${ARGV}")
list(REMOVE_AT FILES 0)
add_library(${NAME}_extension STATIC ${FILES})
target_link_libraries(${NAME}_extension duckdb_static)
endfunction()
We link the Rust lib against ${NAME}_extension.
joseph-isaacs
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.