feat(java): use JNI instead of JNA #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
changed the title
Spark column vectors return `UTF8String`s, which can wrap one of - JVM heap-allocated `String` - JVM heap-allocated `byte[]` - A native pointer + len to native off-heap memory Previously we've been using the String pathway, this PR changes our Java scans to canonicalize on read (`.with_canonicalize(true)`), and sends back to Java a ptr + len pair. This patch when ferried down into Iceberg gives us another 2x speedup on Citibike scan
lwwmanning
reviewed
Mar 25, 2025
| NativeLoader.loadJni(); | ||
| } | ||
|
|
||
| private OptionalLong pointer; |
Contributor
Author
There was a problem hiding this comment.
yea, the idea here is that on close I set it to empty. And then I unwrap the optional before calling into JNI. The goal is to turn something that would be a SEG into a Java NPE. I do this for all of the wrapped classes that have close implemented.
| } | ||
|
|
||
| tasks.withType<Test>().all { | ||
| classpath += |
java/vortex-spark/src/test/java/dev/vortex/spark/VortexScanTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| #[unsafe(no_mangle)] | ||
| pub extern "system" fn Java_dev_vortex_jni_NativeArrayStreamMethods_free( |
lwwmanning
approved these changes
Mar 25, 2025
joseph-isaacs
pushed a commit
that referenced
this pull request
Mar 26, 2025
Switch from JNA -> JNI. On some microbenchmarks I've seen this result in a ~3x speedup for simple string-passing. I wired this into the Iceberg fork for Vortex and am seeing an immediate ~40% speedup on Citibike scan queries Subsequently #2781 gives us another 2x speedup on Citibike.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from JNA -> JNI. On some microbenchmarks I've seen this result in a ~3x speedup for simple string-passing.
I wired this into the Iceberg fork for Vortex and am seeing an immediate ~40% speedup on Citibike scan queries
Subsequently #2781 gives us another 2x speedup on Citibike.