Layout segments size info in TUI #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2833 will improve performances by 24.46%Comparing Summary
Benchmarks breakdown
|
AdamGS
commented
Mar 28, 2025
Comment on lines
-231
to
-232
| // 0th child of a ChunkedLayout is the chunk stats array. | ||
| // The rest of the chunks are child arrays |
Contributor
Author
There was a problem hiding this comment.
We don't do that anymore 🥳
AdamGS
commented
Mar 28, 2025
| } | ||
| } | ||
|
|
||
| pub fn collect_segment_ids(root_layout: &Layout) -> (Vec<SegmentId>, Vec<SegmentId>) { |
Contributor
Author
There was a problem hiding this comment.
ideally this should be somewhere in vortex-layout, but @gatesn is making some changes somewhere and I don't want to conflict him.
onursatici
approved these changes
Mar 28, 2025
Contributor
Author
|
I was waiting for a review, so I also added a stat display for the flat chunks. |
AdamGS
added a commit
that referenced
this pull request
Mar 28, 2025
Thought I pushed this change into #2833 🤦. Display isn't perfect yet but its a step in the right direction. <img width="1559" alt="Screenshot 2025-03-28 at 17 47 19" src="https://github.com/user-attachments/assets/e5133a64-672b-4c32-a0c6-d1f239955583" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into compression/file size and this is just thing I'm adding as I go. The main change here is restoring size info by traversing the segments to get all segments contained within a layout.
Top layout info:
child level info for chunked layout
and struct layout: